Closed g3bk47 closed 3 months ago
Thanks, @speth! I rebased and incorporated all requested changes.
Attention: Patch coverage is 86.04651%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 72.78%. Comparing base (
64ed2b7
) to head (c2a9322
).
Files | Patch % | Lines |
---|---|---|
interfaces/cython/cantera/_onedim.pyx | 66.66% | 3 Missing :warning: |
src/oneD/StFlow.cpp | 88.46% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
Add a new option to compute species diffusive fluxes with respect to their mass fraction gradients for 1D flames. See https://github.com/Cantera/enhancements/issues/195 for extended discussion. All changes are fully backward compatible.
After some brainstoming, I settled on
flux_gradient_basis
as the new property's name, i.e. using mole or mass fraction gradients for computing species fluxes. If you have a better idea, feel free to let me know. I also changed the API to use the established basis enum. Performance-wise, this should not have an impact, since the comparisonm_fluxGradientBasis == ThermoBasis::molar
is a simple hard-coded comparison against zero.Checklist
scons build
&scons test
) and unit tests address code coverage