Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
581 stars 342 forks source link

Fix CI jobs #1671

Closed speth closed 4 months ago

speth commented 4 months ago

Changes proposed in this pull request

Working on fixing the following:



- Fix "Windows 2019" runners which fail during `pip install ...` with the error `ERROR: Invalid requirement: '"scons<4.4.0"'`.

**If applicable, fill in the issue number this pull request is fixing**

<!-- Issues with issue number '<issue>' are referenced as #<issue>. To link to an issue in the enhancements repository, use Cantera/enhancements#<issue>. -->

Closes #

**If applicable, provide an example illustrating new features this pull request is introducing**

<!-- A minimal, complete, and reproducible example demonstrating features introduced by this pull request. See https://stackoverflow.com/help/minimal-reproducible-example for additional suggestions on how to create such an example. -->

**Checklist**

- [x] The pull request includes a clear description of this code change
- [x] Commit messages have short titles and reference relevant issues
- [x] Build passes (`scons build` & `scons test`) and unit tests address code coverage
- [x] Style & formatting of contributed code follows [contributing guidelines](https://github.com/Cantera/cantera/blob/main/CONTRIBUTING.md)
- [x] The pull request is ready for review
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.77%. Comparing base (71e4ccb) to head (72e90c2). Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1671 +/- ## ========================================== - Coverage 72.78% 72.77% -0.01% ========================================== Files 375 375 Lines 56610 56632 +22 Branches 20510 20590 +80 ========================================== + Hits 41201 41212 +11 - Misses 12389 12398 +9 - Partials 3020 3022 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.