Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
580 stars 341 forks source link

Rewrite Jupyter Notebook examples as Python examples #1681

Closed speth closed 2 months ago

speth commented 3 months ago

Changes proposed in this pull request

For all the examples that included diagrams, I re-drew the PNGs in Adobe Illustrator and saved them as SVGs, to avoid having to commit these moderately large binary files into the repo, and because the vector versions just look nicer.

I've added co-author credit in the commit message for the original authors of the Jupyter examples.

Note that this already incorporates the fix to the 1D packed bed example from Cantera/cantera-jupyter#47.

If applicable, fill in the issue number this pull request is fixing

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.69%. Comparing base (0c89553) to head (923af6f). Report is 17 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1681 +/- ## ========================================== + Coverage 72.76% 75.69% +2.93% ========================================== Files 378 443 +65 Lines 56986 60975 +3989 Branches 20691 9551 -11140 ========================================== + Hits 41468 46158 +4690 + Misses 12463 11786 -677 + Partials 3055 3031 -24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.