Closed speth closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.69%. Comparing base (
0c89553
) to head (923af6f
). Report is 17 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
1D_pfr_surfchem.ipynb
, It is almost wholly superseded by theFlowReactor
-based version (1D_pfr_surfchem.py
). The only exception is the "adiabatic" case, but this is problematic because the original reaction kinetics are only valid at a single temperature.batch_reactor_ignition_delay_NTC.ipynb
andnonideal_shock_tube.ipynb
are incorporated into the existingNonIdealShockTube.py
example.lithium_ion_battery.ipynb
was used to update the existinglithium_ion_battery.py
, mainly by including the extended model description.flame_speed_with_sensitivity_analysis.ipynb
was used to update the existingflamespeed_sensitivity.py
twin_premixed_flame_axisymmetric.ipynb
was used to update the existingpremixed_counterflow_twin_flame.py
.I'm not quite sure what to do with. Per @ischoegl's comment below, this example is not being migrated.ck2yaml_demo.ipynb
. Bringing this back into the main repository would bring back in a bunch of CK input data that we deliberately removed, and I'm not sure how useful it is in general compared to the ck2yaml tutorial already in the Users' Guide.For all the examples that included diagrams, I re-drew the PNGs in Adobe Illustrator and saved them as SVGs, to avoid having to commit these moderately large binary files into the repo, and because the vector versions just look nicer.
I've added co-author credit in the commit message for the original authors of the Jupyter examples.
Note that this already incorporates the fix to the 1D packed bed example from Cantera/cantera-jupyter#47.
If applicable, fill in the issue number this pull request is fixing
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage