Closed ischoegl closed 2 months ago
Attention: Patch coverage is 88.09524%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 72.80%. Comparing base (
ed27faf
) to head (a8aae47
). Report is 1 commits behind head on main.:exclamation: Current head a8aae47 differs from pull request most recent head 3f20538. Consider uploading reports for the commit 3f20538 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready for review ... decided to restrict this PR to Reactor cleanup that became possible after the removal of the legacy MATLAB toolbox.
@speth - thank you for your feedback. I believe I started some confusion with a deprecation warning that incorrectly implied that something was introduced in Cantera 3.0, while only being implemented after its release (non-empty Reactors). I updated/corrected the warnings, which should take care of your concerns.
Regarding changes to the reactor content after instantiation, we can definitely think about removing this capability, but either insert
or setSolution
are needed until the deprecation cycle is complete. I agree that any changes should be discussed in a separate PR.
Changes proposed in this pull request
Removal of legacy MATLAB toolbox #1670 allows for some simplifications / deprecations:
setThermoMgr
/setKineticsMgr
for 0DIf applicable, fill in the issue number this pull request is fixing
Partially addresses #1457
_A clean resolution of #1457 will require pushing the Python
_WeakrefProxy
approach to the C++ layer?_Checklist
scons build
&scons test
) and unit tests address code coverage