Closed ischoegl closed 5 months ago
Attention: Patch coverage is 76.11940%
with 16 lines
in your changes are missing coverage. Please review.
Project coverage is 72.75%. Comparing base (
ed27faf
) to head (2c99b2e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
Move sentinels preventing species addition for
ThermoPhase
objects used byReactorBase
,Domain1D
,SolutionArray
andMultiPhase
instances from Python API to C++.The implementation uses reference counters that should only be used within C++ (and not exposed at interfaces). This allows for most
_WeakrefProxy
sentinels to be be removed in Python. One exception isQuantity
, which does not have a C++ equivalent.The approach is relatively simple, and turns out to be independent of migrating various C++ classes to use
Solution
.If applicable, fill in the issue number this pull request is fixing
Closes #1457
Checklist
scons build
&scons test
) and unit tests address code coverage