Closed speth closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.82%. Comparing base (
0c89553
) to head (ad64f36
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
This PR is the implementation of an idea I suggested in https://github.com/Cantera/enhancements/issues/22#issuecomment-2025676862.
example_data
, install these data files when installing CanteraSConstruct
build/data
I don't regard this as the final word on which files belong in the
data
directory of the of this repo and which ones should be moved tocantera-example-data
. So far, I've only moved those data files that were only used in examples into the submodule. If we want to move any other files, it will take a bit of work to extricate them from the test suite.If applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#22
If applicable, provide an example illustrating new features this pull request is introducing
Files from the
cantera-example-data
repository can be loaded by specifying the path relative to the base Cantera data directory:Checklist
scons build
&scons test
) and unit tests address code coverage