Closed corykinney closed 3 weeks ago
What behavior would be expected if no explicit third body species are present in the mechanism?
I didn't try it, but I think your patch would add a blank line to the output. I don't see a problem with that.
@speth I implemented your suggestions and added the necessary test case. It should be good to go, but let me know if I missed anything in the test.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.69%. Comparing base (
d37a76b
) to head (39816e4
). Report is 19 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
This pull request adds a check in
yaml2ck
for third body efficiencies for species that might not be present in thect.Solution
object due to theskip-undeclared-third-bodies: true
flag.Closes #1683
Using the provided example from the issue referenced:
The outputted Chemkin file from
python -m cantera.yaml2ck test.yaml --overwrite
before the change:versus after the change:
The
N2
efficiency is omitted from the list as desired.Feedback
An example file still needs to be added with a corresponding test case, but before doing so, I wanted to solicit feedback on potential edge cases. What behavior would be expected if no explicit third body species are present in the mechanism? Are there any other possible cases that need to be accounted for proactively?
Checklist
scons build
&scons test
) and unit tests address code coverage