Fix reversible reaction behavior in Matlab interface - Githubissues

Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite

https://cantera.org

Other

602 stars 345 forks source link

Fix reversible reaction behavior in Matlab interface #1701

Closed speth closed 3 months ago

speth commented 3 months ago

Changes proposed in this pull request

Matlab: Return 0 as reverse rate constant for irreversible reactions. This behavior is consistent with Python and the default behavior in C++
Matlab: Fix docstring for Kinetics.equilibriumConstants. The equilibrium constant is calculated regardless of whether the reaction is marked as reversible. This is consistent with the behavior of the Python and C++ interfaces.

If applicable, fill in the issue number this pull request is fixing

Fixes #1691

Checklist

[x] The pull request includes a clear description of this code change
[x] Commit messages have short titles and reference relevant issues
[x] Build passes (scons build & scons test) ~~and unit tests address code coverage~~ fixing the Matlab toolbox's tests is out of scope for this PR
[x] Style & formatting of contributed code follows contributing guidelines
[x] The pull request is ready for review