Closed speth closed 2 weeks ago
Attention: Patch coverage is 97.43590%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 75.72%. Comparing base (
026c5c7
) to head (790dd3a
).
Files | Patch % | Lines |
---|---|---|
interfaces/cython/cantera/onedim.py | 95.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm going to leave the Windows .NET CI failure alone for the sake of this PR. I tried testing locally and can't replicate it.
Changes proposed in this pull request
This PR fixes a number of issues with the 1D flame solver.
none
transport model. The stringdefault
needs to be specified to activate the YAML-specified transport model. Resolves #1680TestCounterflowPremixedFlameNonIdeal::test_solve_case1
was previously taking upwards of 30 seconds to run on GitHub Actions.Checklist
scons build
&scons test
) and unit tests address code coverage