Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
580 stars 341 forks source link

Fix issues with 1D flame solver #1705

Closed speth closed 2 weeks ago

speth commented 3 weeks ago

Changes proposed in this pull request

This PR fixes a number of issues with the 1D flame solver.

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.72%. Comparing base (026c5c7) to head (790dd3a).

Files Patch % Lines
interfaces/cython/cantera/onedim.py 95.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1705 +/- ## ========================================== + Coverage 75.69% 75.72% +0.02% ========================================== Files 443 443 Lines 60971 60981 +10 Branches 9552 9557 +5 ========================================== + Hits 46154 46178 +24 + Misses 11786 11777 -9 + Partials 3031 3026 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

speth commented 2 weeks ago

I'm going to leave the Windows .NET CI failure alone for the sake of this PR. I tried testing locally and can't replicate it.