Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
580 stars 341 forks source link

Incorporating the LMR-R mixture rule into Cantera for the first time #1710

Open pjsingal opened 2 weeks ago

pjsingal commented 2 weeks ago

Changes proposed in this pull request

Checklist

[x] The pull request includes a clear description of this code change [x] Commit messages have short titles and reference relevant issues [x] Build passes (scons build & scons test) and unit tests address code coverage [] Style & formatting of contributed code follows contributing guidelines [x] The pull request is ready for review

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0.87719% with 226 lines in your changes missing coverage. Please review.

Project coverage is 75.42%. Comparing base (4565a55) to head (0fc2537). Report is 76 commits behind head on main.

:exclamation: Current head 0fc2537 differs from pull request most recent head a2131a2

Please upload reports for the commit a2131a2 to get more accurate results.

Files Patch % Lines
src/kinetics/LmrRate.cpp 0.00% 198 Missing :warning:
include/cantera/kinetics/LmrRate.h 0.00% 15 Missing :warning:
interfaces/cython/cantera/reaction.pyx 14.28% 12 Missing :warning:
src/kinetics/ReactionRateFactory.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1710 +/- ## ========================================== - Coverage 75.72% 75.42% -0.31% ========================================== Files 443 445 +2 Lines 60981 61197 +216 Branches 9557 9584 +27 ========================================== - Hits 46178 46157 -21 - Misses 11777 12003 +226 - Partials 3026 3037 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.