[Python] Updates for NumPy 2.0 support in the sdist builder

Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite

https://cantera.org

Other

602 stars 345 forks source link

[Python] Updates for NumPy 2.0 support in the sdist builder #1713

Closed bryanwweber closed 3 months ago

bryanwweber commented 3 months ago

Fix a few compiler warnings from Eigen in the Cython interface
Change how the sdist build environment is created
Install example data in the sdist This can be configured by the top-level example_data option
Simplify extension setup to resolve duplicate cythonizing When building the sdist via scons, the cython step was running twice because of the conditional. In addition, we were getting a warning about building the extension from multiple source files. These changes resolve both problems by cythonizing once if the files aren't present and only including the C++ sources in the extension.
Fix build-system dependencies for NumPy 2.0 support NumPy 2.0 does not support Python 3.8, so we need to special case that version. Also special case for Pint, which doesn't support NumPy 2.0 on Python 3.9.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.84%. Comparing base (02b2bff) to head (dc4d0c0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1713 +/- ## ======================================= Coverage 72.84% 72.84% ======================================= Files 379 379 Lines 53824 53824 Branches 9182 9182 ======================================= Hits 39208 39208 Misses 11642 11642 Partials 2974 2974 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryanwweber commented 3 months ago

Related to #1675

corykinney commented 3 months ago

I saw #1675 was closed :tada:

@bryanwweber Is the plan to do some sort of 3.0.0post1 once this work is complete so that a fresh pip install will work again (maybe with Python 3.12 support 😄)?

bryanwweber commented 3 months ago

I saw #1675 was closed 🎉

@bryanwweber Is the plan to do some sort of 3.0.0post1 once this work is complete so that a fresh pip install will work again (maybe with Python 3.12 support 😄)?

I'll probably re-open #1675 until the Conda packages are fixed as well. Then I'll see about backporting :smile: I would like to backport, and see if we can preemptively support Python 3.13 as well