Closed ischoegl closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.80%. Comparing base (
bc24169
) to head (b9a8936
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
Solution
methodsSolutionArray
methods when phase is anInterface
If applicable, fill in the issue number this pull request is fixing
Closes #1717
If applicable, provide an example illustrating new features this pull request is introducing
Comments
This is to make the interface somewhat consistent with
Solution
; there are some differences, e.g. round vs square brackets, or passing of lists vs argument lists, where fixes go beyond the scope of this PR. Also,Solution
currently does not slicegas["O2"].binary_diff_coeffs
correctly, so this PR merely ensures that implementations are mostly consistent.Checklist
scons build
&scons test
) and unit tests address code coverage