Closed bryanwweber closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.04%. Comparing base (
9210b08
) to head (8386395
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@speth I think I addressed everything here :smile:
Thanks @speth! Good suggestions :smile:
Changes proposed in this pull request
scikit-build-core
scikit-build-core
will find system libraries in appropriate places because it uses CMake for configuration:construction: TODO: :construction:
system_packages
are enabled (right now they're forced to be disabled, but we don't need our private copies anymore)scons sdist
doesn't run unnecessary system checksbuild.system-requires
table (see https://github.com/scikit-build/scikit-build-core/issues/806). We do not need to do this because I was wrong about when cmake is installed.If applicable, fill in the issue number this pull request is fixing
Closes Cantera/enhancements#205
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage