Cantera / cantera

Chemical kinetics, thermodynamics, and transport tool suite
https://cantera.org
Other
602 stars 346 forks source link

Add support for HDF5 to sdist/wheels #1727

Closed bryanwweber closed 2 months ago

bryanwweber commented 3 months ago

Changes proposed in this pull request

:construction: TODO: :construction:

If applicable, fill in the issue number this pull request is fixing

Closes Cantera/enhancements#205

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.04%. Comparing base (9210b08) to head (8386395). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1727 +/- ## ======================================= Coverage 73.03% 73.04% ======================================= Files 381 381 Lines 54132 54164 +32 Branches 9233 9240 +7 ======================================= + Hits 39534 39562 +28 + Misses 11635 11633 -2 - Partials 2963 2969 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bryanwweber commented 2 months ago

@speth I think I addressed everything here :smile:

bryanwweber commented 2 months ago

Thanks @speth! Good suggestions :smile: