Closed ischoegl closed 3 months ago
Attention: Patch coverage is 19.87041%
with 371 lines
in your changes missing coverage. Please review.
Project coverage is 73.20%. Comparing base (
74c971d
) to head (08c9ee6
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/clib/ct.cpp | 24.55% | 169 Missing :warning: |
src/clib/ctonedim.cpp | 26.92% | 57 Missing :warning: |
src/clib/ctmultiphase.cpp | 1.78% | 55 Missing :warning: |
src/clib/ctreactor.cpp | 7.14% | 52 Missing :warning: |
src/clib/ctrpath.cpp | 0.00% | 24 Missing :warning: |
src/clib/ctsurf.cpp | 0.00% | 8 Missing :warning: |
src/clib/Cabinet.h | 50.00% | 5 Missing :warning: |
src/clib/ctfunc.cpp | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This makes sense to me, @ischoegl. Just one minor suggestion.
Thanks for the prompt review, @speth! I adopted your suggestion.
Changes proposed in this pull request
This PR is mostly house-keeping for a simple bulk-replacement to streamline CLib's storage class (a left-over item from #1770 which I decided to break down into more manageable chunks)
SharedCabinet::item
bySharedCabinet::at
SharedCabinet::get
by SharedCabinet::as`SharedCabinet::item
andSharedCabinet::get
SharedCabinet
back toCabinet
(original name of before shared pointers were introduced in #1448)Checklist
scons build
&scons test
) and unit tests address code coverage