Closed speth closed 1 month ago
Attention: Patch coverage is 76.47059%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 73.23%. Comparing base (
4a954f9
) to head (6320dd4
). Report is 12 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
interfaces/cython/cantera/func1.pyx | 76.47% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
The stated minimum version of Cython is 0.29.31, in both the documentation of the dependencies and as checked by SCons. However, Cantera currently fails to compile except with Cython 3.0.0 and newer due to differences in the way
__add__
/__radd__
and related operators are implemented.While I expect we'll probably drop support for anything older than Cython 3.0.0 after the Cantera 3.1 release, I'd like to maintain support for these older versions for the time being.
This also updates the CI configuration to make sure we're testing more than just the latest and greatest Cython version.
Checklist
scons build
&scons test
) and unit tests address code coverage