Closed cpilko closed 4 days ago
Hi! Thanks for making this change. I think this is definitely an improvement.
Since you're editing these lines anyways, ideally we would actually change these into full if
statements, raising an appropriate ValueError
. The reason is that interpreter options can be set for Python that disable assert
statements at runtime, so these guards would no longer be effective.
Please also address the changes suggested by the linter: https://github.com/Cantera/cantera/actions/runs/11936944028/job/33273168168?pr=1816, in particular making sure not to introduce any extra spaces at the ends of lines. You can continue to push changes to this branch to update the pull request.
Thank you!
Attention: Patch coverage is 20.00000%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 73.25%. Comparing base (
ad41b31
) to head (27312a5
). Report is 4 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
interfaces/cython/cantera/composite.py | 20.00% | 4 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Thank you! The test failures on macOS don't seem related to the changes here, but let's see what happens this time. I will merge this as soon as the tests look good!
Changes proposed in this pull request
assert
statements in interfaces/cython/cantera/composite.pyCloses #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage