Open ischoegl opened 18 hours ago
Attention: Patch coverage is 0%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 73.25%. Comparing base (
1b48991
) to head (a8dde95
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/thermo/MixtureFugacityTP.cpp | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changes proposed in this pull request
writelog
messages forMixtureFugacity::solveCubic
to exception (no root found) and warning (merged roots) respectively.If applicable, fill in the issue number this pull request is fixing
Band-aid for #1699
The example from #1699 now fails with:
which allows for improved exception handling (rather than checking for invalid densities).
Checklist
scons build
&scons test
) and unit tests address code coverage