After Cantera/cantera#1183 and Cantera/cantera#1181, most Reaction specializations for the 'new' MultiRate-based framework no longer require specializations. It would be good if the following specializations could be eliminated prior to the release of Cantera 2.6
[x] ThreeBodyReaction ... see PR Cantera/cantera#1333
[x] FalloffReaction ... see PR Cantera/cantera#1333
[x] CustomReaction ... see PR Cantera/cantera#1332
[x] ElectrochemicalReaction (via #139 and Cantera/cantera#1216)
What problem is it trying to solve? ... remove all specializations of Reaction
Who is affected by the change? ... any application of Kinetics
Why is this a good solution? ... having a single Reaction implementation (which takes care of the law of mass action) will move all specialized behavior to ReactionRate, which will result in simpler API's.
Possible Solutions
Bulk Phase. The simplest approach would be to introduce BulkRate.h where handling of third-body efficiencies is implemented on a per-reaction basis (this would replace ThirdBodyCalc.h and work in a similar way as CoverageBase in InterfaceRate.h). Within BulkKinetics.h, there then can be two std::vector<unique_ptr<MultiRateBase>> objects: one for regular rates (i.e. m_bulk_rates), and the other one for third-body rates (e.g. m_thirdbody_rates)>. This has the additional advantage that it will be simple to define third-body reactions that use BlowersMaselRate.
Electrochemical Reactions. Again, the simplest solution would be to add two std::vector<unique_ptr<MultiRateBase>> objects: one taking care of regular interface reactions, and the other one being specific to electrochemical reactions. The only thing that needs to be done is to add some electrochemistry-specific information to CoverageData.
In both cases, the identification of third-body and electrochemical reactions can be deferred until very late in the process, i.e. a classification can be avoided until reactions are added by BulkKinetics and InterfaceKinetics, which will allow for the removal of pre-processing steps that happen much earlier.
Abstract
After Cantera/cantera#1183 and Cantera/cantera#1181, most
Reactionspecializations for the 'new'MultiRate-based framework no longer require specializations. It would be good if the following specializations could be eliminated prior to the release of Cantera 2.6ThreeBodyReaction... see PR Cantera/cantera#1333FalloffReaction... see PR Cantera/cantera#1333CustomReaction... see PR Cantera/cantera#1332ElectrochemicalReaction(via #139 and Cantera/cantera#1216)ThirdBodydetectionMotivation
Describe the need for the proposed change:
ReactionKineticsReactionimplementation (which takes care of the law of mass action) will move all specialized behavior toReactionRate, which will result in simpler API's.Possible Solutions
Bulk Phase. The simplest approach would be to introduce
BulkRate.hwhere handling of third-body efficiencies is implemented on a per-reaction basis (this would replaceThirdBodyCalc.hand work in a similar way asCoverageBaseinInterfaceRate.h). WithinBulkKinetics.h, there then can be twostd::vector<unique_ptr<MultiRateBase>>objects: one for regular rates (i.e.m_bulk_rates), and the other one for third-body rates (e.g.m_thirdbody_rates)>. This has the additional advantage that it will be simple to define third-body reactions that useBlowersMaselRate.Electrochemical Reactions. Again, the simplest solution would be to add two
std::vector<unique_ptr<MultiRateBase>>objects: one taking care of regular interface reactions, and the other one being specific to electrochemical reactions. The only thing that needs to be done is to add some electrochemistry-specific information toCoverageData.In both cases, the identification of third-body and electrochemical reactions can be deferred until very late in the process, i.e. a classification can be avoided until reactions are added by
BulkKineticsandInterfaceKinetics, which will allow for the removal of pre-processing steps that happen much earlier.