Cantera / enhancements

Repository for proposed and ongoing enhancements to Cantera
11 stars 5 forks source link

Make handling of Reactor Wall functions consistent #160

Closed ischoegl closed 1 year ago

ischoegl commented 1 year ago

Abstract

Reactor walls define wall_Q as well as wall_vdot in clib, which have an explicit time dependency although the time is known internally (see https://github.com/Cantera/cantera/pull/1182#discussion_r1044943917). The Python API provides non-pythonic setters, and omits getters. An improved solution should be implemented that is consistent across all interfaces.

Motivation

Describe the need for the proposed change:

Possible Solutions

Update underlying C++ functions as needed and adapt Python/Matlab API's.

References

Cantera/cantera#1182