Cantera / enhancements

Repository for proposed and ongoing enhancements to Cantera
11 stars 5 forks source link

Radiation property library #72

Open BYUignite opened 3 years ago

BYUignite commented 3 years ago

Abstract

A brief description of the work being done.

We have developed a radiation property library called radlib (https://github.com/BYUignite/radlib) the implements the Planck Mean (PM), WSGG, and the new RCSLW models. These models provide absorption coefficients and weighting factors that can be combined with a solver for the radiative transport equation. The code is fully documented, verified, and includes several examples. The library is written in C++ and includes a Python interface written in Cython. Each of the three models currently implemented includes CO2, H2O, and soot, with RCSLW including CO, and PM including CO and CH4. One of many advantages of Cantera is that it provides a library of thermochemical and reaction properties that simplify the development of user tools. We would like to include additional radiation properties in Cantera for use in user tools.

Motivation

Describe the need for the work being done:

The models noted seem consistent with the purpose and approach of Cantera. The radlib code is only a starting point and would require appropriate integration into Cantera, which we are willing to do, with some guidance. The Planck Mean model is already implemented in Cantera. We would like to extend the capabilities to other models.

Description Please see https://github.com/BYUignite/radlib for a detailed description, including code documentation: https://ignite.byu.edu/radlib_documentation/. Code examples and plots are shown here: https://github.com/BYUignite/radlib/blob/master/examples/python/run_and_plot_examples.ipynb

Alternatives

If any alternative solutions to solving the same problem have been considered, describe them here, and explain why the chosen approach is preferred.

References

Links to a development branch in your fork of the Cantera repository, Pull Requests, GitHub Issues, Users' Group topics, or other relevant material.

https://github.com/BYUignite/radlib

Note, we are preparing a journal publication on this code. There is also a code ocean module in review.

Sincerely, David Lignell Professor, Brigham Young University http://ignite.byu.edu

bryanwweber commented 3 years ago

Hi @BYUignite! Thank you so much for posting this. I don't have any updates other than to say I'm looking forward to seeing how this can be integrated with Cantera!

BYUignite commented 3 years ago

Hi, thanks Brian, I’m glad this is of interest. I think we last met at the Cantera workshop at the US Combustion Meeting at CalTech. I was the program chair for that meeting, so I was a bit distracted with other things at the time.

I’m a huge fan of Cantera and use it regularly, but I’ve not contributed directly to the code. I would like to do that in ways that would be useful (and always subject to me thinking I have more time than I do :-( I worked with Harry Moffett when he was developing CADS, and I’ve done a lot of work with John Hewson. We are also developing a number of models for representing soot (or other aerosol) size distributions, including sectional, MOMIC, QMOM, DQMOM, and others, and these might be of interest as well.

Perhaps the thing to do with the radiation is to issue a pull request? I can do that, and read the contribution guides, but it’s likely that I’ll run into a couple questions that might be better to have answered before implementing, issuing the request, and then fixing. For example, the RCSLW radiation model reads data from a file and I’d want to put those files in the right place. (They are not configuration files, and the data could be hard-coded, but they are a couple MB, so that’s not ideal.) Similarly, I’d want to make sure the Python (Cython) interface was done right. Is the Cantera group the best place to communicate, or email, (or even phone)?

Best Regards,

David

David O. Lignell Professor, Chemical Engineering Brigham Young University 801-422-1772 | http://ignite.byu.edu

On Jan 12, 2021, at 6:37 PM, Bryan W. Weber notifications@github.com<mailto:notifications@github.com> wrote:

Hi @BYUignitehttps://github.com/BYUignite! Thank you so much for posting this. I don't have any updates other than to say I'm looking forward to seeing how this can be integrated with Cantera!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Cantera/enhancements/issues/72#issuecomment-759145995, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD5XI7MGQMEKVSRPR66OGLDSZT2M5ANCNFSM4U3PG26Q.

ischoegl commented 3 years ago

Hi David, I am posting a link to a current PR Cantera/cantera/pull/965 here that I believe has overlap. I haven’t looked into radiation properties myself at this point, and mainly wanted to connect dots here.

BYUignite commented 3 years ago

Thanks for sharing. This is interesting.

David O. Lignell Professor, Chemical Engineering Brigham Young University 801-422-1772 | http://ignite.byu.edu

On Feb 9, 2021, at 7:28 AM, Ingmar Schoegl notifications@github.com<mailto:notifications@github.com> wrote:

I am posting a link to a current PR Cantera/cantera/pull/965https://github.com/Cantera/cantera/pull/965 here that I believe has overlap. I haven’t looked into radiation properties myself at this point.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Cantera/enhancements/issues/72#issuecomment-775980073, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD5XI7OLKDUBAPYJV6HU47LS6FBCXANCNFSM4U3PG26Q.

lavrenyukiv commented 3 years ago

You use the same polynomials for calculating the Planck-averaged coefficients as https://www.sandia.gov/TNF/radiation.html. It is not clear how accurate these polynomials are at high temperatures (small approximation errors lead to huge deviations in energy), so using linear interpolation in logarithm scale between "exact" values is preferably. Also polynomial for CO2 leads to negative absorption coefficient at low temperatures.

BYUignite commented 3 years ago

Changing the Planck-mean coefficients would be easy to do, and we could guard properly against value ranges.