search

Cantera / enhancements

Repository for proposed and ongoing enhancements to Cantera
11 stars 5 forks source link

A third party package for sensitivity analysis of one-dimensional flame #89

Closed jiweiqi closed 3 years ago

jiweiqi commented 3 years ago

Delete to avoid unintentional advertising of unrelated stuffs

bryanwweber commented 3 years ago

Hi @jiweiqi! Thanks for opening this. This looks like a very interesting effort! Will this require any specific changes to Cantera itself? If not, I'm not sure this is the best place to post about this, the Users' Group might be a better place to advertise this. If there are changes required to Cantera, can you be more specific about them? Thanks!

ischoegl commented 3 years ago

@jiweiqi ... as Bryan said this looks definitely interesting, but I share his questions about the direction of this effort.

@bryanwweber ... as an alternative, per #83 this may be a candidate for ‘show-and-tell’ discussion threads.

bryanwweber commented 3 years ago

@ischoegl good point, it might get more exposure on the UG though

bryanwweber commented 3 years ago

@jiweiqi Since this isn't a proposal for an enhancement to Cantera specifically, I'm going to close it to keep the issues somewhat organized and actionable for the development team. If you'd like to shift this into a feature request for adjoint sensitivity of species in the 1-D module, in addition to the flame speed, I think that'd be more appropriate and you can feel free to edit and reopen the issue to focus around that.

I see you've also commented on #71, which seems to be similar to this one.