PR for CI/CD workflow and broken Cosmos-sdk simulation fix.
Current repo seems that github workflow configuration is not set. You can check the workflow output of this PR from https://github.com/b-harvest/Canto/pull/23 (test PR with the same codebase).
Workflow
[x] build - checking build completed with no errors on PR
[x] test / codecov - checking test coverage for each commit on PR
[x] simulations for cosmos-sdk modules
Simulation
Default simulations for Cosmos-sdk modules were broken. Followings are how we fixed issues:
not increasing block height - because sdk. DefaultPowerReduction in app.go was set to ethermint.PowerReduction, Tendermint recognizes the power of the validator as 0, causing the block not to progress. To resolve this issue, we set manual sdk.DefaultPowerReduction value in each simulation test.
NewValidatorCommissionDecorator in Cosmos anteHandler breaks the simulation - To resolve this issue, SDK modification is required and to avoid this, a new separated anteHandler for simulation is introduced.
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
[x] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[x] included the necessary unit and integration tests
[x] reviewed "Files changed" and left comments if necessary
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
[ ] confirmed all author checklist items have been addressed
Description
PR for CI/CD workflow and broken Cosmos-sdk simulation fix. Current repo seems that github workflow configuration is not set. You can check the workflow output of this PR from https://github.com/b-harvest/Canto/pull/23 (test PR with the same codebase).
Workflow
Simulation
Default simulations for Cosmos-sdk modules were broken. Followings are how we fixed issues:
sdk. DefaultPowerReductioninapp.gowas set toethermint.PowerReduction, Tendermint recognizes the power of the validator as 0, causing the block not to progress. To resolve this issue, we set manualsdk.DefaultPowerReductionvalue in each simulation test.NewValidatorCommissionDecoratorin Cosmos anteHandler breaks the simulation - To resolve this issue, SDK modification is required and to avoid this, a new separated anteHandler for simulation is introduced.ChainID- EVM rejects the invalid ChainID and it breaks the simulation. To fix this issue, proper chain ID is set when creating a newctx.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...