issues
search
Canto-Network
/
Canto
Layer-1 blockchain powered by Free Public Infrastructure
GNU Lesser General Public License v3.0
83
stars
80
forks
source link
[Discussion] Policy Decision on BlockedAddrs in SDK v0.50 bump
#122
Open
dongsam
opened
6 months ago
dongsam
commented
6 months ago
Context:
Currently upgrading to SDK v0.50
https://github.com/b-harvest/Canto/pull/53
Discrepancies found in
BlockedAddrs
between v0.50 simapp and Canto's implementation during upgrade.
Differences and Suggestions:
Gov Module Account:
v0.50 simapp allows token receiving in gov module account, not blocked in
BlockedAddrs
, unlike Canto.
This change was due to a
https://github.com/cosmos/cosmos-sdk/pull/12852
aiming to handle CommunityPool -> IBC transfer via gov module account.
Suggestion: If no similar case is planned in Canto, keeping gov module in
BlockedAddrs
might minimize potential risks.
Distribution Module Account:
v0.50 simapp disallows token receiving in distribution module account, but Canto currently allows it.
This was an exception from
Canto's initial setup
, with unclear intent.
Suggestion: Blocking the distribution module account in
BlockedAddrs
to minimize risks unless there's an unidentified reason to allow it.
Context:
BlockedAddrs
between v0.50 simapp and Canto's implementation during upgrade.Differences and Suggestions:
BlockedAddrs
, unlike Canto.BlockedAddrs
might minimize potential risks.BlockedAddrs
to minimize risks unless there's an unidentified reason to allow it.