remove funcs like Route, Type, GetSignBytes, GetSigners because they are supported by protobuf. But in case of MsgConvertERC20, GetSigners func is alive and implemented GetSignersFromMsgConvertERC20V2 func additionally.(ref. https://github.com/b-harvest/Canto/pull/53#discussion_r1574149712)
v8 package bump will be done in a separate pr after this pr is merged to avoid amplification of file changes in that pr
x/onboarding module is a feature-driven of the ibc. So, need to ensure that features don't behave differently compared to canto v7, as the version of the ibc-go bump up.
as the versions of different modules in go.mod are upgraded, need to ensure that there are no security issues.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] included the necessary unit and integration tests
[ ] reviewed "Files changed" and left comments if necessary
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
[ ] confirmed all author checklist items have been addressed
Description
Closes: #XXXX
Key dependency changes:
notable changed files
app
modules
ValidateBasic
logic to msg_serverprotobuf
. But in case ofMsgConvertERC20
, GetSigners func is alive and implemented GetSignersFromMsgConvertERC20V2 func additionally.(ref. https://github.com/b-harvest/Canto/pull/53#discussion_r1574149712)msg level
soauthority
has been added to the required module.(ref. https://github.com/cosmos/cosmos-sdk/issues/10952)KVStoreService
as opposed to the prev way of accessing KVStore via store key.(ref. https://github.com/cosmos/cosmos-sdk/pull/16324, ...)NOTE
v8 package bump
will be done in a separate pr after this pr is merged to avoid amplification of file changes in that prx/onboarding
module is a feature-driven of theibc
. So, need to ensure that features don't behave differently compared to canto v7, as the version of theibc-go
bump up.go.mod
are upgraded, need to ensure that there are no security issues.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...