feat: Canto v8 - Githubissues

dudong2 commented 3 months ago

Description

Key dependency changes:

Cosmos-SDK v0.45.9 to v0.50.8
CometBFT (Tendermint) v0.34.25 to v0.38.9
ibc-go v3.2.0 to v8.3.2
go-ethereum v1.10.19 to v1.10.26

remained tasks

package name bump (v7 -> v8)
security patch

The above 2 tasks must be completed before release.

notable changed files

app

app.go
- align the overall code with the structure of the cosmos-sdk's app.go, except for some parts related canto's modules and issue(ref. https://github.com/Canto-Network/Canto/issues/122)
ante
- name change and few other structural changes related to authz and issue(ref. https://github.com/Canto-Network/Canto/issues/124)
upgrades.go
- add migration code due to upgrade of cosmos-sdk and ibc-go

modules

cli
- remove legacy REST(ref. https://github.com/cosmos/cosmos-sdk/pull/9594)
msgs
- move ValidateBasic logic to msg_server
- remove funcs like Route, Type, GetSignBytes, GetSigners because they are supported by protobuf. But in case of MsgConvertERC20, GetSigners func is alive and implemented GetSignersFromMsgConvertERC20V2 func additionally.(ref. https://github.com/b-harvest/Canto/pull/53#discussion_r1574149712)
- the module-specific proposal handler and param change was switched to msg level so authority has been added to the required module.(ref. https://github.com/cosmos/cosmos-sdk/issues/10952)
keeper
- KVStore has been changed to use KVStoreService as opposed to the prev way of accessing KVStore via store key.(ref. https://github.com/cosmos/cosmos-sdk/pull/16324, ...)

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] included the necessary unit and integration tests
[ ] reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

poorphd commented 3 months ago

@tkkwon1998 Can you review this PR?