Canto-Network / Canto

Layer-1 blockchain powered by Free Public Infrastructure
GNU Lesser General Public License v3.0
83 stars 75 forks source link

Correct the go.mod v2 <> v5.0.0 mismatch #82

Closed ChristianBorst closed 1 year ago

ChristianBorst commented 1 year ago

It is impossible to import a Canto module (e.g. GovShuttle) with a version mismatch in go.mod, in particular go get github.com/canto-network/canto/v2@v5.0.0 will panic with the following error: invalid version: module path includes a major version suffix, so major version must match

The next step is to release a v5.0.1 version including this commit.

faddat commented 1 year ago

Sir, I disagree.

why is gov shuttle versioned v5.0.0? ohhhh dude I get it!

yeah man I'm. in. But it wont be just go.mod that we change. Got to do all of the import paths. I am going to pull your branch into mine, and you'll still get the commit. I think you solved a problem I was facing that was frankly a huge pita. Thank you.

faddat commented 1 year ago

Yep. it worked. totally critical to making my PR work.

🤝

safe to close, this is in #81