Canvasbird / canvasboard

An interactive board with plugins focusing on replacing the need of multiple platforms for teaching, presenting, managing or explaining your ideas.
MIT License
198 stars 119 forks source link

fix slideshow bug, initialized slides after the content is loaded #430

Closed aguyran closed 3 years ago

aguyran commented 3 years ago

Issue that this pull request solves

Closes: #428

Proposed changes

Brief description of what is fixed or changed

Assigned a empty this.deck and initialized with new Reveal object every time ngAfterView triggers, so it assigns relevant classes after every render

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

goliakshay357 commented 3 years ago

Hello @aguyran, LGTM!!. Feel free to check #431 #432

Thanks for the update :)