Canvasbird / canvasboard

An interactive board with plugins focusing on replacing the need of multiple platforms for teaching, presenting, managing or explaining your ideas.
MIT License
198 stars 119 forks source link

Issue 327 - Unique folder name create/update #436

Closed Kevan-Y closed 3 years ago

Kevan-Y commented 3 years ago

Issue that this pull request solves

Closes: #327

Proposed changes

Brief description of what is fixed or changed

Adding a check to check if the folder names already exist. Fix the CSS to display error in modal

Types of changes

Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

goliakshay357 commented 3 years ago

Hello @Kevan-Y, Thanks for the update. I see one issue when you don't try to change the name.

Steps to produce the bug:

  1. Create a new folder say demo1
  2. Clock on edit folder name.
  3. Now without editing the name, click on green tick.
  4. You get an error for saving the save name.

Generally when you don't change anything in the name, it should accept the existing name. image

Steps to produce another similar bug:

  1. Create a folder with the same name as an existing one.
Kevan-Y commented 3 years ago

@goliakshay357 Fixed, I also removed some duplicate code that was caused by some commit in master

goliakshay357 commented 3 years ago

Hello @Kevan-Y, Thanks for the enhancement :)