Login and sign up will now continue on enter to improve flow

Dinoosawruss commented 3 years ago

Issue that this pull request solves

Closes: #452

Proposed changes

This allows you to press enter and login/signup instead of mousing to the button or pressing tab to get to the button

Brief description of what is fixed or changed

Added (keyup.enter) events

Types of changes

Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist

Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface N/A UI has not visibly changed

Other information

Any other information that is important to this pull request

Feel free to add comment or ask any questions, if you would like something changed let me know

welcome[bot] commented 3 years ago

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ Canvasboard is an interactive board with plugins focusing on replacing the need of multiple platforms for teaching, presenting or explaining your ideas. The interactive plugins are built using web technologies to ease your work right within a single platform. Please adhere to our Code of Conduct.🙌 We will get back to you as soon as we can 😄. Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

goliakshay357 commented 3 years ago

Hello @Dinoosawruss, There are a few merge conflicts to be resolved. Can you please checkout at your convenience, so I can merge the PR.

Thanks

Dinoosawruss commented 3 years ago

@goliakshay357 conflicts should be resolved and all should be working as intended

Dinoosawruss commented 3 years ago

@goliakshay357 Not sure if you've seen my update - all conflicts should be resolved

goliakshay357 commented 3 years ago

Hello @Dinoosawruss, Yes I have! Sorry but the event is not getting fired when the enter keyword is pressed.

Preview and testing Link: https://deploy-preview-457--canvasboard.netlify.app/home

Dinoosawruss commented 3 years ago

Hello @Dinoosawruss, Yes I have! Sorry but the event is not getting fired when the enter keyword is pressed.

Preview and testing Link: https://deploy-preview-457--canvasboard.netlify.app/home

That's weird let me take a look if its working on my local files

Dinoosawruss commented 3 years ago

@goliakshay357 Should be working now

goliakshay357 commented 3 years ago

@Dinoosawruss, Yes. Thanks for the update!

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! 🎉 All the best for your amazing open source journey ahead 🚀.

Canvasbird / canvasboard