CaoRuiming / bpr-wordpress

Wordpress site for brownpoliticalreview.org
Other
2 stars 3 forks source link

Eliminate redundant social media icons in top navigation #73

Closed CaoRuiming closed 3 years ago

CaoRuiming commented 3 years ago

There are currently two icon <div> elements for every social media icon in the top navigation bar (e.g. facebook, twitter, instagram). One version is shown for light mode and one is shown for dark mode.

This is redundant. We should have a single html element for every icon and switch the actual icon image in the CSS depending on light/dark mode.

Look at the commit 5b3d44f for the general approach to this issue.