Detect native packages - Githubissues

WcaleNieWolny commented 10 months ago

This PR adds the following things:

bundle compatibility command to check if the bundle that we are trying to upload is compatible with the latest channel.
A --auto-min-update-version option to automatically set the minUpdateVersion used when the disallow update strategy is enabled.

Here is a more detailed explanation and a showcase:

First the compatibility table:

This handles well all edge cases: When there is a dependency in the remote version but not locally (Dependency has been removed):

When the version has changed locally (update)

When the version has changed locally (downgrade from remote)

When a new dependency has been added:

Next this adds the --auto-min-update-version to the upload command. Here is how it looks:

(This flag is useful only when the metadata strategy is used for disabling updates)

The important thing is that there was some manifest in supabase, however the CLI deemed the remote version to not be compatible with the remote currently uploaded version.

Since the new version is not compatible a app store update is required. Thus the min version is the 1.0.31.

Now, let's upload a new version. This time we will not change any native dependency

Well the latest version uploaded to capgo was deemed to be compatible with this new version. Thus an update is possible and the min update version is also 1.0.31

However sometimes you will not have a previous min update version available. (For example because you have just enabled the metadata disallow strategy). In that case you probably want to manually configure it instead of it having it auto generated

This change is not breaking. If there is no metadata the CLI will fail nicely

As for the upload flag. If there is no metadata the update is assumed to be breaking thus we set the min update version to bundle number

Schema change: https://github.com/Cap-go/capgo/pull/419 /claim #87

WcaleNieWolny commented 10 months ago

I have wrote tests for this feature. Those are available here

I will not be using the bot to run them as I am still awaiting the supabase base.sql fix pr to be merged and right now the bot would fail to start supabase thus the tests would fail.

However I will proved an output from my local machine here