search

Cap-go / capacitor-inappbrowser

Capacitor plugin in app browser with urlChangeEvent
MIT License
57 stars 37 forks source link

Add support to specify request credentials #148

Open avioli opened 2 weeks ago

avioli commented 2 weeks ago

Added a way to specify known username/password credentials for requests before opening the in-app browser.

I had a need to specify a username and password for an in-app browser that my app is showing. In my case - the credentials are stored in the device's keystore/keychain, so they are known in advance and I don't want the in-app browser to request them.

NOTE: that the definitions.ts has the credentials prop listed as available since version 6.1.0, so you may need to adjust that if you decide to merge this request.

avioli commented 2 weeks ago

I just want to mention that I haven't run npm run fmt or rather reverted after I ran it, since it produces more changes that I think it's worth it for me to commit. These are cosmetic, so I guess that - if you merge this request - you will run it anyways.

riderx commented 2 weeks ago

Thanks for the PR! I just checked on main npm run fmt produce no changes, so it's important you run it on your branch before I merge :) Otherwise nice work i will merge it after that !