search

Cap-go / capacitor-inappbrowser

Capacitor plugin in app browser with urlChangeEvent
MIT License
58 stars 37 forks source link

feat: Add reload button in openWebView #74

Closed ayusham001 closed 9 months ago

ayusham001 commented 10 months ago

/claim #73

riderx commented 10 months ago

Hey @ayusham001 thanks for adding this feature. i think the task wasn't clear enought the need was of having the button in the top bar, not callable from JS, even that nice feature. let's keep that one i will create a bounty for it, and if you can solve the initial bounty, it will be 2 claim then

ayusham001 commented 10 months ago

Hey @riderx Thank you for your feedback! I apologize for the misunderstanding regarding the initial task, I'm glad you like the feature Please review the changes.

ayusham001 commented 10 months ago

Hello @riderx, it seems like the issue has been closed. What about the feature I added that is callable from JS?

riderx commented 10 months ago

Can you fix your conflict, I will tips you then

ayusham001 commented 10 months ago

Hi @riderx, I have resolved some conflicts. Please take a look at it and let me know if there are any further requirements. Thank you.

ayusham001 commented 10 months ago

Hi @riderx, Just checking in with you since it has been a while. Please revert back to this whenever you find it suitable, I will be looking forward to your reply.

riderx commented 10 months ago

i'm not sure to understand what revert you talk about ^^ i saw you added in pakcage json a peer dep of the package itself, I think that a mistake, can you update it ?

ayusham001 commented 10 months ago

Hi @riderx I have made some changes Please have a look on it

riderx commented 10 months ago

@ayusham001 thanks it only miss the typescript definition now :)

ayusham001 commented 10 months ago

@riderx Check it out :)

riderx commented 10 months ago

Can you run build command, fmt, and verify ?

ayusham001 commented 10 months ago

@riderx I have made the necessary changes that I found needed.

ayusham001 commented 10 months ago

Hi @riderx, Hopefully, you have looked into my recent changes to the PR. Please provide me with the necessary feedback.

riderx commented 10 months ago

/tip 50

algora-pbc[bot] commented 10 months ago

🎉🎈 @ayusham001 has been awarded $50! 🎈🎊

riderx commented 10 months ago

Thanks a lot !

ayusham001 commented 10 months ago

Thank you @riderx for your support and consideration.

riderx commented 9 months ago

Hey @ayusham001 seems you got the tip plus the reward as well. I know it could look nice for you. But this was not supposed to happen. I'm happy about your work, and I was comfortable to tip you, but right now it feels a bit unfair to the original one PR. So I have asked Algora team to take a look on this. Hope you understand

ayusham001 commented 9 months ago

Hello @riderx, yes I noticed the update right now. Of course, it was a little sad to see the reward get refunded since I worked hard for the PR, but I also understand your point. Besides, I trust your judgment of the same. I am grateful for the tip and my PR getting merged. Thank you.