Cap-go / capacitor-inappbrowser

Capacitor plugin in app browser with urlChangeEvent
MIT License
58 stars 37 forks source link

Fixed Build Issues and fixed issue #70 #81

Closed PrabhbirJ closed 10 months ago

PrabhbirJ commented 10 months ago

This is a running build checked for android. Let me know if there are any issues on either platform. Thank you. /claim #70

WcaleNieWolny commented 10 months ago

Also, please do not close this PR just to open another one. It makes reviewing changes hard.

WcaleNieWolny commented 10 months ago

Good job on the error handling and documentation 💪

PrabhbirJ commented 10 months ago

Good job on the error handling and documentation 💪

Thank you. Open source is a new thing for me so had to try out a bunch of things just to get started.

WcaleNieWolny commented 10 months ago

If you do not mind some feedback I strongly recommend that you do not close PRs just to reopen them later then you fix the issues mentioned in the review and I also recommend that you do not force push a total revert of all your changes into your branch. If you want to submit only 1 commit you can squash your commits or request that a maintainer squashes them when merging (GH has an option to easily squash entire branch when merging a PR)

PrabhbirJ commented 10 months ago

Thank you @WcaleNieWolny for your tips. I’ll keep it in my mind for the next contributions.

riderx commented 10 months ago

/tip $20 @WcaleNieWolny

algora-pbc[bot] commented 10 months ago

🎉🎈 @WcaleNieWolny has been awarded $20! 🎈🎊

riderx commented 10 months ago

@PrabhbirJ i don't understand, your code don't build in the CI did you runned your code locally ?

PrabhbirJ commented 10 months ago

@riderx Sorry about the extension issue. I tested my additions to the code on the swift playground but missed where to add the extension UIColor part in the actual code. Thanks for resolving that out.

riderx commented 10 months ago

@PrabhbirJ it's ok it can happen. I found an other issue, if you change the color of the bar the button have a background color and look not nice. If you know how to fix that that can be nice

riderx commented 10 months ago

CleanShot 2023-09-07 at 01 58 29@2x

riderx commented 10 months ago

ok i fixed it