search

Cap-go / capacitor-inappbrowser

Capacitor plugin in app browser with urlChangeEvent
MIT License
58 stars 37 forks source link

Dispose WebView after closing #94

Closed c01nd01r closed 3 months ago

c01nd01r commented 7 months ago

Hello! I noticed that WebView in Android is not being destroyed after it's closed. As far as I can see in the plugin code (I'm not an Android developer), there is no explicit call to the webView.destroy() method anywhere.

Is this the correct behavior? Should it be fixed, even though it might break backward compatibility in some cases? I recorded my observation on video.

screen recording https://github.com/Cap-go/capacitor-inappbrowser/assets/3511312/7c96f625-119a-4f0a-aefa-2712f427ff7a
riderx commented 3 months ago

Can you open a Pr with your change?

riderx commented 3 months ago

i added it already after you report and forgot to tell you thanks for the report

c01nd01r commented 3 months ago

i added it already after you report and forgot to tell you thanks for the report

Awesome! Thank you so much 🤝