search

CapPow / HerbASAP

An effort to automate image post processing for natural history collections
GNU General Public License v3.0
8 stars 3 forks source link

output_map is poorly organized #27

Closed CapPow closed 5 years ago

CapPow commented 5 years ago

in postProcessing.py the setup_Output_Handler() function creates output_map which is later passed to the save_output_images() in the folderMonitor.py. The output_map is only used to pass off the user preferences for which image types to save and the path to store them. The output_map is poorly organized and has difficult to read syntax. It could use cleaning up or simplifying.

CapPow commented 5 years ago

the output_map is now inside the mainapp class in postProcessing.py. It is generated by setup_Output_Handler() and called in save_output_images()

CapPow commented 5 years ago

For now this is clarified somewhat using inline comments. This can be re-opened if it remains an issue or if anyone proposes a better solution.