CapSoftware / Cap

Open source Loom alternative. Beautiful, shareable screen recordings.
https://cap.so
GNU Affero General Public License v3.0
4.65k stars 233 forks source link

Cap.so/favicon.ico is using the default Next.js favicon #128

Open reynaldichernando opened 2 hours ago

reynaldichernando commented 2 hours ago

Description

The favicon for the cap.so website is using the default vercel/next.js triangle icon.

https://cap.so/favicon.ico https://cap.so/favicon.ico

Reproduction

or, open cap.so landing page

If opened in Safari, it will show the triangle icon.

image

If opened in Chrome, it will show the correct icon.

image

However, this is because Chrome is fetching the https://cap.so/favicon-32x32.png icon version.

image

Additional Context

reynaldichernando commented 2 hours ago

The reason this happens is that, there are 2 favicon.ico files in the landing page. apps/web/app/favicon.ico

apps/web/public/favicon.ico

And seems like in production next.js, it is prioritizing the one in the app directory.

However, in development, it will show the conflicting file error.

image
reynaldichernando commented 2 hours ago

The fix should be fairly straightforward, simply by removing the default favicon.ico from the app directory, so it uses the correct favicon from the public directory. Will submit a PR for this!