CapSoftware / Cap

Open source Loom alternative. Effortless, instant screen sharing.
https://cap.so
GNU Affero General Public License v3.0
3.63k stars 169 forks source link

Combine Ffmpeg commands into one single command (macOS) #24

Closed richiemcilroy closed 1 month ago

richiemcilroy commented 4 months ago

Right now, there are two separate commands for capturing audio and video. They can be found in media.rs located in apps/desktop/src-tauri. I would like to have them combined into one single ffmpeg command to reduce system load when recording.

Requirements

You can use this guide to help you get started developing locally as quickly as possible.

richiemcilroy commented 4 months ago

/bounty $100

algora-pbc[bot] commented 4 months ago

💎 $200 bounty • Cap

Steps to solve:

  1. Start working: Comment /attempt #24 with your implementation plan
  2. Submit work: Create a pull request including /claim #24 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to CapSoftware/Cap!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🔴 @webbdays Apr 11, 2024, 3:11:38 PM WIP
🟢 @Brendonovich Jun 13, 2024, 8:21:35 AM #46
webbdays commented 4 months ago

/attempt

Algora profile Completed bounties Tech Active attempts Options
@webbdays 1 bounty from 1 project
Python, Rust,
JavaScript & more
Cancel attempt
webbdays commented 4 months ago

@richiemcilroy some example usage of the command?

richiemcilroy commented 4 months ago

@webbdays here's a link to where both of the separate commands are located;

https://github.com/CapSoftware/Cap/blob/main/apps/desktop/src-tauri/src/media.rs#L418

webbdays commented 4 months ago

yes, i would like to have idea of using command with both type of inputs.

richiemcilroy commented 4 months ago

@webbdays it's possible but requires the use of fifo named pipes so that ffmpeg can read from the two input sources from one command.

Or if there's an alternative method with a better approach that can also be used.

webbdays commented 4 months ago

ok.

webbdays commented 4 months ago

Currently, i am not full-fledged working on this. others with ideas can attempt this issue.

ologbonowiwi commented 4 months ago

Make sure the recording process is still performant after changing

do we have any sort of benchmark to run before and after?

richiemcilroy commented 4 months ago

I guess the benchmark is just making sure that the screen capture and microphone recording is being created from a single ffmpeg command instead of two currently

ologbonowiwi commented 4 months ago

Where are recordings saved on the dev environment (without S3 enabled)?

Also, do I need a running mysql to run the app locally?

Brendonovich commented 2 months ago

/attempt #24

algora-pbc[bot] commented 2 months ago

💡 @Brendonovich submitted a pull request that claims the bounty. You can visit your bounty board to reward.

richiemcilroy commented 1 month ago

/bounty $200

algora-pbc[bot] commented 1 month ago

🎉🎈 @Brendonovich has been awarded $200! 🎈🎊