CapceleaCristian / ReactPhoneStore

Phone Store using ReactJS
0 stars 0 forks source link

Store/Redux refactor #1

Open strdr4605 opened 5 years ago

strdr4605 commented 5 years ago

The store/redux is ok but can be improved:

My suggestions:

A separate file for action constants is not mandatory, as all constants can be stored in actions.js file. If you want to keep them in a separate file may be better to rename types.js :arrow_right: constants.js. But I will go with approach of keeping actions constants in actions.js.

Useful link: Choosing the best folder structure for your React application

strdr4605 commented 5 years ago

@CapceleaCristian https://redux.js.org/style-guide/style-guide#structure-files-as-feature-folders-or-ducks https://github.com/erikras/ducks-modular-redux