search

Capgemini / archaius-spring-adapter

Bringing Archaius-goodness to the world of Spring
Apache License 2.0
30 stars 15 forks source link

Add PMD to the build #29

Closed rhart closed 10 years ago

rhart commented 10 years ago

http://maven.apache.org/plugins/maven-pmd-plugin/

rhart commented 10 years ago

@andrewharmellaw I had to make some changes to the exception handling as a result of this, you prob need to code review ArchaiusSpringPropertyPlaceholderSupport

andrewharmellaw commented 10 years ago

@rhart - late to the game, but I've taken a look and it seems nice to me.

rhart commented 10 years ago

The thing we need to discuss I guess (and I should have already) is whether we're happy to fail the build. I know people usually have strong views on this both ways.

Personally I feel it gives people confidence that what they're submitting is of good code quality. And helps with consistency, makes requests easier to read etc. But I know there is an argument that it discourages pull requests. Maybe there is a balance to achieve by switching more rules off maybe. Especially one's that cause us to have to use "ignore" annotations.

andrewharmellaw commented 10 years ago

I say we make it fail the build. We should have a page on the wiki on how to submit a pull request, our code style, the fact that failing the build due to this isn't a problem. There's a good example of something similar at job-dsl. [1]

[1] https://github.com/jenkinsci/job-dsl-plugin/blob/master/CONTRIBUTING.md

Andrew Harmel-Law twitter: @al94781 http://twitter.com/al94781 blog: the-music-of-time.blogspot.com flickr: flickr.com/photos/andrewbrucelaw

On 24 June 2014 13:22, rhart notifications@github.com wrote:

The thing we need to discuss I guess (and I should have already) is whether we're happy to fail the build. I know people usually have strong views on this both ways.

Personally I feel it gives people confidence that what they're submitting is of good code quality. And helps with consistency, makes requests easier to read etc. But I know there is an argument that it discourages pull requests. Maybe there is a balance to achieve by switching more rules off maybe. Especially one's that cause us to have to use "ignore" annotations.

— Reply to this email directly or view it on GitHub https://github.com/Capgemini/archaius-spring-adapter/issues/29#issuecomment-46963942 .