Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
113 stars 6 forks source link

Task create form radio #371

Closed cg-julian-taylor closed 1 year ago

daniele-zurico commented 1 year ago

@cg-julian-taylor thanks for your PR however there're some observations:

  1. renameStyledRadio.stories.mdx with Styled.stories.mdx to maintain the same convention
  2. the unstyled one is not displaying correctly you need to verify it (for example the first item say error and some radio is not clickable)
  3. I suppose you need to rebase this branch with your feature branch given I still see in storybook, under form, the Group documentation and the Radio documentation
cg-julian-taylor commented 1 year ago

@cg-julian-taylor thanks for your PR however there're some observations:

  1. renameStyledRadio.stories.mdx with Styled.stories.mdx to maintain the same convention
  2. the unstyled one is not displaying correctly you need to verify it (for example the first item say error and some radio is not clickable)
  3. I suppose you need to rebase this branch with your feature branch given I still see in storybook, under form, the Group documentation and the Radio documentation

You are correct. I think for point 3 The leftover stories were meant to be removed in a later step. But I could do that now to avoid confusion.