Closed szilvihorvath closed 1 year ago
Hey @szilvihorvath really well done on your PR. It's almost perfect. I had a look on the gds toolkit documentation and I found out more scenario that we should take in consideration like the following:
[x] it doesn't stop you writing but change the message when you over the limit (became red)
[x] it counts the letters (maxlength)
[x] it counts the words (maxwords)
[x] it allow a threeshold after that the message appear (maxlength: 112, threshold: 75)
Please can you also keep an eye on the styled version (govUk)... I feel like some classes are not correctly implemented. Probably the class govuk-textarea
should make the job.
Patch coverage: 100.00
% and no project coverage change
Comparison is base (
cf21f21
) 100.00% compared to head (2d15b2a
) 100.00%.:exclamation: Current head 2d15b2a differs from pull request most recent head 86a1b0c. Consider uploading reports for the commit 86a1b0c to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Issue: https://github.com/Capgemini/dcx-react-library/issues/414
Created new CharacterCount component.
Key features: