Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
113 stars 6 forks source link

Feature/character count component #419

Closed szilvihorvath closed 1 year ago

szilvihorvath commented 1 year ago

Issue: https://github.com/Capgemini/dcx-react-library/issues/414

Created new CharacterCount component.

Key features:

daniele-zurico commented 1 year ago

Hey @szilvihorvath really well done on your PR. It's almost perfect. I had a look on the gds toolkit documentation and I found out more scenario that we should take in consideration like the following:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (cf21f21) 100.00% compared to head (2d15b2a) 100.00%.

:exclamation: Current head 2d15b2a differs from pull request most recent head 86a1b0c. Consider uploading reports for the commit 86a1b0c to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/0.7 #419 +/- ## ============================================= Coverage 100.00% 100.00% ============================================= Files 45 46 +1 Lines 1029 1075 +46 Branches 400 428 +28 ============================================= + Hits 1029 1075 +46 ``` | [Impacted Files](https://codecov.io/gh/Capgemini/dcx-react-library/pull/419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini) | Coverage Δ | | |---|---|---| | [src/characterCount/CharacterCount.tsx](https://codecov.io/gh/Capgemini/dcx-react-library/pull/419?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2NoYXJhY3RlckNvdW50L0NoYXJhY3RlckNvdW50LnRzeA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.