Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
113 stars 7 forks source link

Button - add new properties #466

Closed daniele-zurico closed 1 year ago

daniele-zurico commented 1 year ago

For the button component, we want to provide two more properties to support in the future the design system tokens:

The className property needs to provide the ability:

  1. for the developer to provide his own class
  2. needs to have the className dcx-button hardcoded (please use the utility classNames)

If the variant property is specified needs to provide the ability to choose between primary|secondary|tertiary so the className will become `dcx-button--[variant]

some examples:

Please follow these steps to create your branch:

git checkout release/0.8
git pull
git checkout -b 'feature/button-new-props'
daniele-zurico commented 1 year ago

closed by https://github.com/Capgemini/dcx-react-library/pull/490