Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
111 stars 7 forks source link

Fix: CharacterCount component not resetting red error text after valid input #471

Closed nikkialgar closed 1 year ago

nikkialgar commented 1 year ago

Fixes bug #463 where error class is assigned correctly when user inputs more than expected characters into CharacterCount component but didn't get removed.

Triggers error:

Screenshot 2023-05-04 at 17 17 59

Resets error class when user corrects input:

Screenshot 2023-05-04 at 17 18 07

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b368e20) 100.00% compared to head (7de37a3) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/0.8 #471 +/- ## ============================================= Coverage 100.00% 100.00% ============================================= Files 61 61 Lines 1202 1203 +1 Branches 457 458 +1 ============================================= + Hits 1202 1203 +1 ``` | [Impacted Files](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini) | Coverage Δ | | |---|---|---| | [src/characterCount/CharacterCount.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2NoYXJhY3RlckNvdW50L0NoYXJhY3RlckNvdW50LnRzeA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

byohannes commented 1 year ago

Hi @daniele-zurico, I have fixed the bug; please review in your time