Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
111 stars 7 forks source link

Feature/autocomplete update value #496

Closed Ahmet-K closed 1 year ago

Ahmet-K commented 1 year ago

This fix addresses an issue (https://github.com/Capgemini/dcx-react-library/issues/462) where the Autocomplete component was not updating when the defaultValue prop was changed.

By this fix, whenever the defaultValue prop changes, the component will re-render, and the input element will correctly display the updated defaultValue.

It includes the test. I have commented out the fix in order to intentionally see the test failing. Once I have confirmed that the test is failing as expected, then I uncommented the fix and verified that the test passes as intended.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/0.8@1b674cd). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/0.8 #496 +/- ## =============================================== Coverage ? 100.00% =============================================== Files ? 50 Lines ? 1121 Branches ? 447 =============================================== Hits ? 1121 Misses ? 0 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.