Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
113 stars 6 forks source link

feat: Tabs are now non-js compliant #506

Closed sri-viswanathan closed 1 year ago

sri-viswanathan commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5200564) 100.00% compared to head (b4b0989) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/0.8 #506 +/- ## ============================================= Coverage 100.00% 100.00% ============================================= Files 67 67 Lines 1239 1240 +1 Branches 460 458 -2 ============================================= + Hits 1239 1240 +1 ``` | [Impacted Files](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini) | Coverage Δ | | |---|---|---| | [src/tabGroup/TabGroup.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL3RhYkdyb3VwL1RhYkdyb3VwLnRzeA==) | `100.00% <100.00%> (ø)` | | | [src/tabGroup/components/Tab.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL3RhYkdyb3VwL2NvbXBvbmVudHMvVGFiLnRzeA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Ibabalola commented 1 year ago

Hi, The Tab Component from dcx-library is not working in non-JS mode. In non-JS it is only showing the first tab content whereas we need all the content from all the tabs.

sri-viswanathan commented 1 year ago

Hi @Ibabalola , ah, I see. I deliberately did it that way (i.e. displaying only the content for the active tab) but am happy to make the change to display the content for all tabs when JS is disabled. Apart from that, can you please confirm that the right content displays when you click on different tabs with JS disabled or are you seeing only the first tab's content regardless of which tab you click?

sri-viswanathan commented 1 year ago

Also @daniele-zurico , please can you confirm that release 0.8.0-rc1 contains the code from this PR? The anchor tags for the tabs should have a new attribute called data-tab-id but I don't see that attribute when I use 0.8.0-rc1.