Closed sri-viswanathan closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
5200564
) 100.00% compared to head (b4b0989
) 100.00%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi, The Tab Component from dcx-library is not working in non-JS mode. In non-JS it is only showing the first tab content whereas we need all the content from all the tabs.
Hi @Ibabalola , ah, I see. I deliberately did it that way (i.e. displaying only the content for the active tab) but am happy to make the change to display the content for all tabs when JS is disabled. Apart from that, can you please confirm that the right content displays when you click on different tabs with JS disabled or are you seeing only the first tab's content regardless of which tab you click?
Also @daniele-zurico , please can you confirm that release 0.8.0-rc1
contains the code from this PR? The anchor tags for the tabs should have a new attribute called data-tab-id
but I don't see that attribute when I use 0.8.0-rc1
.
:target
CSS pseudoclass to show and hide contentTab.tsx
, replaceid
withdata-tab-id
as this was creating duplicate IDs on the page, i.e., both the tab and the tabpanel had the same value for theid
attributeexample
project to use React 18'sReactDOM.createRoot
instead ofReactDOM.render