search

Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
111 stars 7 forks source link

Label Design System #515

Closed JadhavJeet closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a18937) 100.00% compared to head (056c14e) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/0.8 #515 +/- ## ============================================= Coverage 100.00% 100.00% ============================================= Files 67 67 Lines 1239 1239 Branches 460 460 ============================================= Hits 1239 1239 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

cg-mmirca commented 1 year ago

Great work Jeet the PR looks really good! 👏 👏

I'll just make some small suggestions on selected lines if you don't mind.

cg-mmirca commented 1 year ago

You got all the key elements in place Jeet! :)

Probably only missing the themes stories?

cg-mmirca commented 1 year ago

Thank you again Jeet, everything looks good from my side :)

I just pushed some adjustments for the accessible and dark themes. Improving the color contrast against the background.