Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
107 stars 7 forks source link

Feature/ds button #520

Closed jgonza16 closed 10 months ago

jgonza16 commented 11 months ago

Solved issue ds-button

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1579a81) 100.00% compared to head (003175b) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #520 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 50 56 +6 Lines 1119 1163 +44 Branches 447 453 +6 ========================================= + Hits 1119 1163 +44 ``` | [Impacted Files](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini) | Coverage Δ | | |---|---|---| | [src/autocomplete/Autocomplete.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2F1dG9jb21wbGV0ZS9BdXRvY29tcGxldGUudHN4) | `100.00% <100.00%> (ø)` | | | [src/autocomplete/ResultList.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2F1dG9jb21wbGV0ZS9SZXN1bHRMaXN0LnRzeA==) | `100.00% <100.00%> (ø)` | | | [src/button/Button.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2J1dHRvbi9CdXR0b24udHN4) | `100.00% <100.00%> (ø)` | | | [src/heading/Heading.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2hlYWRpbmcvSGVhZGluZy50c3g=) | `100.00% <100.00%> (ø)` | | | [src/insertText/InsertText.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2luc2VydFRleHQvSW5zZXJ0VGV4dC50c3g=) | `100.00% <100.00%> (ø)` | | | [src/keyBoard/KeyboardInput.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2tleUJvYXJkL0tleWJvYXJkSW5wdXQudHN4) | `100.00% <100.00%> (ø)` | | | [src/label/Label.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2xhYmVsL0xhYmVsLnRzeA==) | `100.00% <100.00%> (ø)` | | | [src/link/Link.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL2xpbmsvTGluay50c3g=) | `100.00% <100.00%> (ø)` | | | [src/paragraph/Paragraph.tsx](https://app.codecov.io/gh/Capgemini/dcx-react-library/pull/520?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Capgemini#diff-c3JjL3BhcmFncmFwaC9QYXJhZ3JhcGgudHN4) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

daniele-zurico commented 11 months ago

Hi @jgonza16 it looks a great PR ... I had a quick walk through and I realised that:

jgonza16 commented 11 months ago

@daniele-zurico thank!! Solved pointer and rebase!!