Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
107 stars 7 forks source link

Pre-formatted text Design System #575

Closed JadhavJeet closed 7 months ago

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (release/1.0.0@fafe140). Click here to learn what that means.

:exclamation: Current head 68a64cf differs from pull request most recent head f32d40d. Consider uploading reports for the commit f32d40d to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/1.0.0 #575 +/- ## ================================================= Coverage ? 100.00% ================================================= Files ? 67 Lines ? 1240 Branches ? 458 ================================================= Hits ? 1240 Misses ? 0 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mmirca commented 7 months ago

thank you for the amazing work Jeet! The only thing I see we could add for this component is a new token for the pre_body font-family. Maybe something like?

"font-family-pre_body": "monospace"
JadhavJeet commented 7 months ago

thank you for the amazing work Jeet! The only thing I see we could add for this component is a new token for the pre_body font-family. Maybe something like?

"font-family-pre_body": "monospace"

Comment resolved