Capgemini / dcx-react-library

React Library UI/UX agnostic
https://main--6069a6f47f4b9f002171f8e1.chromatic.com
MIT License
107 stars 7 forks source link

FormRadio and FormInput Component does not offer a capability to not add an aria-label #621

Closed Ibabalola closed 2 months ago

Ibabalola commented 2 months ago

Describe the bug Form Radio takes name as an aria-label when one is not provided however I need the aria-label attribute to be deleted as it overrides the visible label and the already existing programmatic association between the and the

Expected behavior When the aria-label property is not provided do not add it to the radio

Line 45 in the src/formRadio/FormRadio.tsx file ariaLabel={ariaLabel || name}

daniele-zurico commented 2 months ago

closed by https://github.com/Capgemini/dcx-react-library/pull/622